Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken tests for the components with setters in Input #191

Closed
GlebIrovich opened this issue Mar 24, 2021 · 5 comments
Closed

Broken tests for the components with setters in Input #191

GlebIrovich opened this issue Mar 24, 2021 · 5 comments
Labels

Comments

@GlebIrovich
Copy link
Contributor

Hey there! I noticed, that updating to 10.4.1 cause some of my tests failing. I investigated a bit and it seems, that the components, which are using setters in the inputs are not invoking logic that was in the setter before.

I assume it might be caused by this change in 10.2.1 which changes the way how component properties are added to the fixture:

function setComponentProperties<SutType>(

I am curios , is it a bug? And if not, what is the preferred way to test components which use set in the @Input?

@timdeschryver
Copy link
Member

Oh shoot, it could be a bug.
It seems like we don't have any tests to cover this behavior, because it should "just" work.

Can you perhaps create PR with a fix, or a test with the expected behavior?

@GlebIrovich
Copy link
Contributor Author

@timdeschryver thanks for clarification! I have no experience contributing to an open source project, but it seems like a sign to give a shot. I will prepare a PR with tests at least.

@timdeschryver
Copy link
Member

Thank you in advance!
If it takes too long, or if you're having troubles feel free to ask for help, or just to paste the test here 🙂

@GlebIrovich
Copy link
Contributor Author

here is a PR

Let me know if I missed anything

@github-actions
Copy link

🎉 This issue has been resolved in version 10.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants