-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken tests for the components with setters in Input #191
Comments
Oh shoot, it could be a bug. Can you perhaps create PR with a fix, or a test with the expected behavior? |
@timdeschryver thanks for clarification! I have no experience contributing to an open source project, but it seems like a sign to give a shot. I will prepare a PR with tests at least. |
Thank you in advance! |
here is a PR Let me know if I missed anything |
🎉 This issue has been resolved in version 10.4.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hey there! I noticed, that updating to 10.4.1 cause some of my tests failing. I investigated a bit and it seems, that the components, which are using setters in the inputs are not invoking logic that was in the setter before.
I assume it might be caused by this change in 10.2.1 which changes the way how component properties are added to the fixture:
angular-testing-library/projects/testing-library/src/lib/testing-library.ts
Line 203 in 4b6e491
I am curios , is it a bug? And if not, what is the preferred way to test components which use
set
in the@Input
?The text was updated successfully, but these errors were encountered: