Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-close stream buffers at the end of the request cycle #52

Closed
testinfected opened this issue Oct 29, 2016 · 0 comments
Closed

Auto-close stream buffers at the end of the request cycle #52

testinfected opened this issue Oct 29, 2016 · 0 comments

Comments

@testinfected
Copy link
Owner

testinfected commented Oct 29, 2016

If the request body is too large to be allocated on the heap, Simple will allocate a file buffer instead of a memory buffer. Same for file uploads. We need to keep track of those buffers that are opened and close them at the end of the request cycle to avoid file descriptors leaks.

testinfected added a commit that referenced this issue Oct 29, 2016
Close input streams after draining, which is the typical use case.

See #52
@testinfected testinfected modified the milestone: v0.11 - Undertow Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant