-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: builder docker/node and sdk-js #1158
Conversation
We have to make Some things such as We can keep using |
Yeah, I think struct tags will do for the casing. And for IPNet, there's actually a marshaller/unmarshaller you can use. Let me try digging it up! |
|
d3e9603
to
e10e830
Compare
Update: ping-pong test working! |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM!
Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>
I'm going to address the comments and then merge! |
This PR is aligned with the efforts in testground/sdk-js#1.
docker/node
builder with the following base Dockerfile:example-js
with the following tests:example-js/pingpong
to CI