Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: testground/testground#909
Similarly to the old prometheus metrics, I have placed the metrics namedpaced under runenv.M()
The metrics are output once every second.
go-metrics has a Log() method which accepts a logger, however the output is human-readable rather than machine-readable. This is clearly not what we want.
The simple way to write logs to metrics.out in json format is simply to open a Writer and write to it. In order to get zap logging to work, I added a simple Writer which writes to the zap log.
I think we don't need or want both. I would, I think, ditch the zap logging and keep the metrics.log output, @raulk what do you think?