Don't blow up when imitating a thing with generators on it #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testdouble.js does not yet support faking generators, full stop. Just return the actual function and fake any properties tacked onto them instead.
|
My feeling is I should probably go with the isPrimitiveLike patch and rename it to something more intent-revealing like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
td.js does not yet support generator functions and we don't have a concept of faking / imitating them since their stubbing needs are quite different from standard functions. However, as of the 3.2 release, anything users imitate that contain native generators will explode. This should fix that.
The latter approach is cleaner and less likely to taint generators, but would prevent imitation of any user-defined properties on it. The former is more surgical in that it's possible we mess up something on the generators' prototype like next()
Fixes #273, #271