Increased Timeout #9373
Closed
Increased Timeout #9373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Puja <pujakarakoti070203@gmail.com>
kiview
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Hi @pujakarakoti07,
this does not fix #9191, it just increases the constant without making it configurable (which moves the race condition border forward, but does not solve it in a user-specific way).
For making it configurable, please look at how it is done for other configuration values in TestcontainersConfiguration.
Signed-off-by: Puja <pujakarakoti070203@gmail.com>
|
@kiview can you please review this? |
|
Hi @pujakarakoti07, unfortunately those changes are not related to what is expected as part of the issue. I had the changes locally and I have submitted #9417. Thanks anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9191
I have increased the Pull TimeOut Configuration by 3 mins.
PULL_RETRY_TIME_LIMIT = 3 in RemoteDockerImage.java