-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add small delay in while loop to avoid spamming logs (ResourceReaper) #2287
Add small delay in while loop to avoid spamming logs (ResourceReaper) #2287
Conversation
|
||
try { | ||
// sleep for a moment to avoid excessive log spam | ||
Thread.sleep(500); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have RateLimiter available on classpath, could you please consider using it instead?
Also, 500ms is rather long initial delay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, of course.
… - Replaced Thread.sleep with RateLimiter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - happy to approve.
Thanks for this @worldtiki.
…tcontainers#2287) * Add small delay in while loop to avoid spamming logs (ResourceReaper) * Add small delay in while loop to avoid spamming logs (ResourceReaper) - Replaced Thread.sleep with RateLimiter
Released in 1.13.0! Thanks for the contribution @worldtiki 😃 |
…tcontainers#2287) * Add small delay in while loop to avoid spamming logs (ResourceReaper) * Add small delay in while loop to avoid spamming logs (ResourceReaper) - Replaced Thread.sleep with RateLimiter
No description provided.