Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with shaded dependencies after upgrade from 1.6.0 to 1.7.1 #656

Closed
eksd opened this issue Apr 23, 2018 · 3 comments
Closed

Problem with shaded dependencies after upgrade from 1.6.0 to 1.7.1 #656

eksd opened this issue Apr 23, 2018 · 3 comments
Labels
area/shading type/bug
Milestone
1.7.3

Comments

@eksd
Copy link

eksd commented Apr 23, 2018 •
edited
Loading

Hi! I've just upgraded my testcontainers for postgres from 1.6.0 to 1.7.1 and there is problem with resolving commons-io and commons-lang dependencies wich are required in testcontainers.
They are shaded in build.gradle of testcontainers, so I have:

Caused by: java.lang.NoClassDefFoundError: org/apache/commons/io/IOUtils at org.testcontainers.jdbc.ContainerDatabaseDriver.runInitScriptIfRequired(ContainerDatabaseDriver.java:234) at org.testcontainers.jdbc.ContainerDatabaseDriver.connect(ContainerDatabaseDriver.java:158) at com.zaxxer.hikari.util.DriverDataSource.getConnection(DriverDataSource.java:117) at com.zaxxer.hikari.util.DriverDataSource.getConnection(DriverDataSource.java:123)

If I add these deps in my pom, problem is solved.

Why are these deps shaded?
@bsideup bsideup added this to the next milestone May 2, 2018
@bsideup bsideup mentioned this issue May 15, 2018
Merged
@bsideup
Copy link
Member

bsideup commented May 15, 2018

Hi @eksd,
Thanks for reporting this one, nice catch!
We shade our internal dependencies (e.g. utils), but apparently the shading was only applied to the main module.
I've submitted a PR with a fix, will be released soon 👍

@hartmut-nex
Copy link

thx, run into the same issue

@bsideup bsideup mentioned this issue May 16, 2018
Closed
@bsideup
Copy link
Member

bsideup commented May 17, 2018

Released as 1.7.3

schauder added a commit to spring-projects/spring-data-relational that referenced this issue May 17, 2018
@schauder
DATAJDBC-213 - Upgraded testcontainers dependency.
09a7276 
This fixes build failures on Travis-CI.
There is an additional test depency to apache commons necessary due to a bug in the testcontainers version.

See also: testcontainers/testcontainers-java#656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/shading type/bug
Projects
None yet
Milestone
1.7.3
Development

No branches or pull requests
3 participants
@bsideup @eksd @hartmut-nex