-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add neo4j license agreement customization options #2036
Add neo4j license agreement customization options #2036
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the options require a specific Docker image for Neo4j? I'd like to have a test or a testable example demonstrating the usage of this options
Oh I saw this late:
What will happen when the options are passed with a non-enterprise image? Will that be a NOOP? |
Yes indeed a no-op. /to @mdelapenya |
So then it's fine to pass the options in a non-enterprise image, right? Then, having a test/example would make it to be merged |
e05b2ab
to
a133992
Compare
I've pushed some tests proving that @mdelapenya |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding the test and for contributing to the module. Much appreciated!
What does this PR do?
This PR adds the ability to use the Neo4j Enterprise Edition docker image by setting the correct environment variable.
Why is it important?
Many production-ready users of Neo4j use the Enterprise edition. Some features can only be tested on the Enterprise edition.
Related issues
I haven't opened a concomitant Issue, @mdelapenya let me know if I should open one.
How to test this PR
Simply run a container with image tag
enterprise
(i.e.neo4j:enterprise
) with the new option and see that the container does not crash immediately with the following error:Details