Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Azure Data Explorer Kusto emulator module #963

Merged
merged 21 commits into from
Aug 7, 2023

Conversation

JonasBenz
Copy link
Contributor

What does this PR do?

Introduces a Azure Data Explorer Kusto emulator module.
The documentation about it can be found here: https://learn.microsoft.com/en-us/azure/data-explorer/kusto-emulator-install

Why is it important?

Simplifies the setup of a Kusto testcontainer with all necessary parameters and a robust Wait strategy.
Having a specific KustoContainer also enables custom extension methods, strong typing, ...

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit b665b1f
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/64d11e9bbcdc570008c362a3
😎 Deploy Preview https://deploy-preview-963--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JonasBenz JonasBenz changed the title Kustainer Azure Data Explorer Kusto emulator module Aug 2, 2023
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR and contribution. I have some minor suggestions. Maybe we can use the HTTP wait strategy implementation instead of the custom wait strategy (dunno if we need the JSON payload). Happy to merge the PR afterward.

src/Testcontainers.Kusto/KustoBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.Kusto/KustoBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.Kusto/KustoContainer.cs Outdated Show resolved Hide resolved
@JonasBenz
Copy link
Contributor Author

Thanks for your PR and contribution. I have some minor suggestions. Maybe we can use the HTTP wait strategy implementation instead of the custom wait strategy (dunno if we need the JSON payload). Happy to merge the PR afterward.

Thanks for the fast feedback 👍
After you merged, do we have to wait for the next release until the *.Kusto NuGet will be available? Or when can we expect it be published?

@HofmeisterAn
Copy link
Collaborator

HofmeisterAn commented Aug 3, 2023

After you merged, do we have to wait for the next release until the *.Kusto NuGet will be available? Or when can we expect it be published?

I have planned a new release, end of this week. I can wait until this PR is ready and do it afterward.

@HofmeisterAn HofmeisterAn self-requested a review August 7, 2023 10:57
HofmeisterAn
HofmeisterAn previously approved these changes Aug 7, 2023
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! PR looks good.

@HofmeisterAn HofmeisterAn changed the base branch from develop to main August 7, 2023 16:42
@HofmeisterAn HofmeisterAn changed the base branch from main to develop August 7, 2023 16:42
@HofmeisterAn HofmeisterAn merged commit bad5b70 into testcontainers:develop Aug 7, 2023
9 checks passed
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Aug 7, 2023
@HofmeisterAn HofmeisterAn changed the title Azure Data Explorer Kusto emulator module feat: Add Azure Data Explorer Kusto emulator module Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants