Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not dispose a custom HTTP message handler in an HTTP wait strategy #958

Merged
merged 3 commits into from
Jul 29, 2023
Merged

fix: Do not dispose a custom HTTP message handler in an HTTP wait strategy #958

merged 3 commits into from
Jul 29, 2023

Conversation

jacobjmarks
Copy link
Contributor

Resolves #957

@netlify
Copy link

netlify bot commented Jul 28, 2023 •
edited
Loading

✅ Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 63258e5
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/64c48235f8749f0007c590db
😎 Deploy Preview https://deploy-preview-958--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jacobjmarks jacobjmarks force-pushed the bug/http-wait-strategy-disposal branch from 4a6b545 to 963cd7f Compare July 28, 2023 03:27
@jacobjmarks jacobjmarks mentioned this pull request Jul 28, 2023
Closed
@jacobjmarks jacobjmarks changed the title Prevent custom HTTP message handler disposal within HTTP wait strategy fix: Prevent custom HTTP message handler disposal within HTTP wait strategy Jul 28, 2023
@HofmeisterAn HofmeisterAn added the bug Something isn't working label Jul 29, 2023
@HofmeisterAn HofmeisterAn changed the title fix: Prevent custom HTTP message handler disposal within HTTP wait strategy fix: Do not dispose a custom HTTP message handler in an HTTP wait strategy Jul 29, 2023
HofmeisterAn
HofmeisterAn approved these changes Jul 29, 2023
View reviewed changes
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for the PR and your contribution.

@HofmeisterAn HofmeisterAn merged commit 556fd41 into testcontainers:develop Jul 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HofmeisterAn HofmeisterAn HofmeisterAn approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: HttpWaitStrategy disposes custom HttpMessageHandler
2 participants
@jacobjmarks @HofmeisterAn