Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: KafkaException (timeout) while creating a topic #849

Merged

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

Changes the KAFKA_ADVERTISED_LISTENERS broker configuration. It replaces the test host (hostname or IP) with the container IP address.

Why is it important?

This is a regression and a misconfiguration of the Kafka module. The fix is necessary for certain Docker environments (non Docker Desktop).

Related issues

@HofmeisterAn HofmeisterAn added the bug Something isn't working label Mar 27, 2023
@HofmeisterAn HofmeisterAn marked this pull request as ready for review March 27, 2023 08:26
@netlify
Copy link

netlify bot commented Mar 27, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit edb35a2
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/64215337b954130007b64856
😎 Deploy Preview https://deploy-preview-849--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@HofmeisterAn HofmeisterAn merged commit 393dc93 into develop Mar 27, 2023
@HofmeisterAn HofmeisterAn deleted the bugfix/845-kafka-failed-while-waiting-for-controller branch March 27, 2023 08:59
@WojciechNagorski
Copy link
Contributor

I found the same problem and I can confirm that this fix works perfectly.

Do you know when this fix will be released?

@HofmeisterAn
Copy link
Collaborator Author

I cannot promise it, but perhaps we can do it next week or the week after. I am waiting for a few small changes that we need to include in the upcoming release. In the meantime, you can simply override the WithStartupCallback configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error in StartupCallback script (KafkaContainer)
2 participants