feat: Add container builder member to depend on other Docker resources #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
HofmeisterAn
commented
Mar 13, 2023
|
|
||
| public Task DisposeAsync() | ||
| { | ||
| return _container.DisposeAsync().AsTask(); |
There was a problem hiding this comment.
@cristianrgreco @eddumelendez @mdelapenya @kiview Currently, dependent resources are not being removed when the parent container is disposed, as these resources might be shared across different configurations. Ryuk is responsible for cleaning them up.
My idea is to maintain an internal reference counter that increments with every create call. When the reference counter equals 1, we can remove the dependent resources as well (while disposing the parent). WDYT?
A general review would be appreciated. PR contains minor general improvements..
HofmeisterAn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request adds the member
DependsOn(IContainer)to the container builder, allowing it to depend on other containers. Internally, we will create and start the dependent containers (resources) first. The same applies for networks and volumes. Please note that we do not have an overloaded member for network and volume. Instead, we use the equivalent memberWithNetwork(INetwork)andWithVolumeMount(Ivolume, string).Why is it important?
This makes it easier for developers to configure test environments and configurations that depend on other resources. We can also use it internally, for example, the WebDiver container configuration will be much simpler.
Related issues
Follow-ups