Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Remove legacy TestcontainersNetworkBuilder, IDockerNetwork #804

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

This pull request replaces the legacy class TestcontainersNetworkBuilder, including its corresponding interface IDockerNetwork, with NetworkBuilder and INetwork.

Why is it important?

It removes obsolete code and prepares the next Testcontainers for .NET release.

Related issues

-

@HofmeisterAn HofmeisterAn added the breaking change Causing compatibility issues label Feb 24, 2023
@netlify
Copy link

netlify bot commented Feb 24, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 177bc5f
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/63f91ac4d9eb7d000868e47c
😎 Deploy Preview https://deploy-preview-804--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@HofmeisterAn HofmeisterAn merged commit 8c0fedb into develop Feb 24, 2023
@HofmeisterAn HofmeisterAn deleted the feature/remove-backwards-compatible-interfaces branch February 24, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Causing compatibility issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant