fix(#783): Dispose container while Resource Reaper is disabled #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
HofmeisterAn
changed the title
HofmeisterAn
deleted the
bugfix/783-dispose-container-if-rr-is-disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Assigns the Resource Reaper session ID to all resources, but starts the Resource Reaper only if it is enabled.
Why is it important?
Sometimes it is necessary to disable Ryuk. Some CI enviroments cannot run Ryuk. Disabling Ryuk disabled
DisposeAsync()too. CallingDisposeAsync()did not remove containers on a successful test run. Although,DisposeAsync()is not reliable and Ryuk is preferred to clean up test environments, we can at least try to clean up resources for environments that do not support Ryuk.Related issues