Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add MinIO module #760

Merged
merged 19 commits into from
Feb 8, 2023
Merged

Conversation

dominikus1993
Copy link
Contributor

What does this PR do?

Add support for Minio test containers.

Why is it important?

I think that adding this testcontainer will be useful for developers who want to test the operation of aws s3

Related issues

How to test this PR

Running the new integration test will suffice.

@netlify
Copy link

netlify bot commented Feb 7, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 94bc87b
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/63e39ab011946c00085db52a
😎 Deploy Preview https://deploy-preview-760--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this pull request! Just a couple of minor tweaks are needed before we can merge it. Once these have been addressed, I'll be happy to merge it into the develop branch. Looking forward to seeing the final version!

src/Testcontainers.Minio/MInioContainer.cs Outdated Show resolved Hide resolved
src/Testcontainers.Minio/MInioContainer.cs Outdated Show resolved Hide resolved
src/Testcontainers.Minio/MinioBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.Minio/MinioBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.Minio/MinioBuilder.cs Outdated Show resolved Hide resolved
tests/Testcontainers.Minio.Tests/MinioContainerTests.cs Outdated Show resolved Hide resolved
tests/Testcontainers.Minio.Tests/MinioContainerTests.cs Outdated Show resolved Hide resolved
tests/Testcontainers.Minio.Tests/MinioContainerTests.cs Outdated Show resolved Hide resolved
tests/Testcontainers.Minio.Tests/MinioContainerTests.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, module looks good 👍. I will merge it later and add some code formatting.

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Feb 8, 2023
@HofmeisterAn HofmeisterAn changed the title add minio testcontainer feat: Add MinIO module Feb 8, 2023
@HofmeisterAn HofmeisterAn merged commit 1d051db into testcontainers:develop Feb 8, 2023
@HofmeisterAn
Copy link
Collaborator

Relates to #747.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants