fix: Trim relative path indicators from Dockerfile path #1203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The pull request removes the relative path indicators from the Dockerfile path in the
WithDockerfile(string)
image builder API.Why is it important?
This change is necessary to prevent issues when a developer passes a relative path to the API, such as
./Dockerfile
. If the Dockerfile path starts with a relative path indicator, the.dockerignore
negate pattern that makes sure the Dockerfile is always included in the tarball might not work correct. This can result in the Dockerfile not being included. Building the image fails with the following or a similar error:Trimming the relative path indicators prevents a follow-up issue. If the path contains relative path indicators, setting the
ImageBuildParameters.Dockerfile
property causes the build to fail as well.Related issues