Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add default file permission (755 for image build) #1176

Merged
merged 1 commit into from
May 13, 2024

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

Applies the default file permission (755) in the tarball that is later sent to the Docker daemon to build the image.

Why is it important?

Without setting the default permissions on Windows test hosts, the relevant ENTRYPOINT and CMD commands may not be able to access (read) files from the working directory (if the user context changes).

Related issues

@HofmeisterAn HofmeisterAn added the bug Something isn't working label May 13, 2024
Copy link

netlify bot commented May 13, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 616b77e
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/664231c536d864000859f489
😎 Deploy Preview https://deploy-preview-1176--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn merged commit 4d791f4 into develop May 13, 2024
14 checks passed
@HofmeisterAn HofmeisterAn deleted the bugfix/1171-apply-default-permissions branch May 13, 2024 17:54
@danielcrabtree
Copy link

Looks good to me. Thanks for getting this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: .NET 8 Container Permissions Changed Breaking Non-Root App User
2 participants