feat: Add pulsar module #1138
Closed
feat: Add pulsar module #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
HofmeisterAn
added
enhancement
|
I believe this pull request is a duplicate. I’ve already submitted a pull request that adds Pulsar support. You can find it here: PR #1103. |
eddumelendez
approved these changes
Apr 19, 2024
eddumelendez
requested changes
Apr 19, 2024
| var content = await response.Content.ReadAsStringAsync() | ||
| .ConfigureAwait(false); | ||
|
|
||
| return "[\"standalone\"]".Equals(content, StringComparison.OrdinalIgnoreCase); |
There was a problem hiding this comment.
if PULSAR_PREFIX_clusterName env var is set then the wait strategy will fail. It should check the env var's value first.
There was a problem hiding this comment.
As @entvex mentioned, there is already an open PR. We should focus on one implementation.
HofmeisterAn
reviewed
Jun 2, 2024
There was a problem hiding this comment.
Thanks for the PR, but as mentioned, someone else already submitted an Apache Pulsar module. I will close this PR since we merged #1103.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for starting Apache Pulsar containers.
Why is it important?
This is required to write tests that target Apache Pulsar.
How to test this PR