Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Invert #if NETSTANDARD* conditional compilation conditions #1079

Merged
merged 2 commits into from
Dec 28, 2023
Merged

chore: Invert #if NETSTANDARD* conditional compilation conditions #1079

merged 2 commits into from
Dec 28, 2023

Commits on Dec 26, 2023

  1. chore: Invert #if NETSTANDARD* conditional compilation conditions 

    While conceptually .NET 5, 6, 7, 8 are greater than .NET Standard 2.1 it does not apply to the `NETSTANDARD2_1_OR_GREATER` macro.

So it's safer to conditionally compile on NETSTANDARD2_0 and assume that the #else branch targets a newer framework where the new bits are available in order not to use the old code path on the newest frameworks.
    @0xced
    0xced committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    40597dd View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. chore: Keep ConfigureAwait in macro if-else

    @HofmeisterAn
    HofmeisterAn committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    ed07855 View commit details
    Browse the repository at this point in the history