Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename the file CouchDbContainerTest.cs to CouchbaseContainerTest.cs #1067

Merged

Conversation

mgroves
Copy link
Contributor

@mgroves mgroves commented Dec 7, 2023

What does this PR do?

Changes a filename

Why is it important?

Reduces confusion by matching the filename to the class within it. The confusion between CouchDb and Couchbase has plagued both databases for years, so this is yet another small, but meaningful, step towards clarity.

Related issues

This is a proposed fix for #1066

How to test this PR

I don't think any testing is necessary, it's just a filename in a test project.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 0d7b884
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/6571f942e7cff50008fa08b5
😎 Deploy Preview https://deploy-preview-1067--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn changed the title #1066 file rename to reduce confusion chore: Rename the file CouchDbContainerTest.cs to CouchbaseContainerTest.cs Dec 7, 2023
@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Dec 7, 2023
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 Thanks, this looks like a leftover from migrating to the new modules API.

@HofmeisterAn HofmeisterAn merged commit 8dfc951 into testcontainers:develop Dec 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants