chore: Replace custom wait strategy with default strategies #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@HofmeisterAn can you please review? |
HofmeisterAn
reviewed
Dec 3, 2023
|
Thanks for the PR. I would like to keep some of the previous implementations, but most of it looks good. Thanks! |
HofmeisterAn
added
the
chore
HofmeisterAn
changed the title
HofmeisterAn
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replacing redundant custom wait strategy implementations with the corresponding IWaitForContainerOS methods.
Why is it important?
Ensuring all modules are consistent and removing redundant code.
How to test this PR
Run the corresponding tests projects for the changed modules.