Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add Support for Aspire Standalone Dashboard #1190

Open
NikiforovAll opened this issue Jun 6, 2024 · 3 comments
Open

[Enhancement]: Add Support for Aspire Standalone Dashboard #1190

NikiforovAll opened this issue Jun 6, 2024 · 3 comments
Labels
enhancement New feature or request module An official Testcontainers module

Comments

@NikiforovAll
Copy link

Problem

As a developer, I want to be able to use Test Monitoring, Aspire provides great local dev experience for that

Ref: https://www.honeycomb.io/blog/monitoring-unit-tests-opentelemetry

Solution

Add Testcontainers.AspireDashboard to this repository.

Benefit

The test monitoring scenario is covered.

Alternatives

It is quite easy to configure AspireDashboard based on common abstractions, but I think it makes good use for others. This is why I would like to contribute to this repo by adding this package.

Would you like to help contributing this enhancement?

Yes

@NikiforovAll NikiforovAll added the enhancement New feature or request label Jun 6, 2024
@HofmeisterAn
Copy link
Collaborator

Interesting idea, thanks for sharing the article. I think I could use something like this in another project. You mentioned you are interested in contributing a module; do you need any guidance or have questions on how to start? I doubt I have time to begin the implementation soon, but I can certainly provide support with feedback and reviews.

@NikiforovAll
Copy link
Author

NikiforovAll commented Jun 11, 2024

I think I can do something based on the following: https://github.com/NikiforovAll/tests-instrumentation-with-otel-and-aspire

I would be happy to contribute, I will take a look at the documentation

ref: https://github.com/NikiforovAll/tests-instrumentation-with-otel-and-aspire/blob/main/tests/Api.IntegrationTests/WebAppFixture.cs

@NikiforovAll
Copy link
Author

I have design-related questions:

  1. It only makes sense to use Aspire with reusable value and persist it during test runs, do we want to make it as default?
  2. It makes sense to expose Aspire on the well-known port by default 18888. What do you think?

NikiforovAll added a commit to NikiforovAll/testcontainers-dotnet that referenced this issue Jun 11, 2024
@HofmeisterAn HofmeisterAn added the module An official Testcontainers module label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module An official Testcontainers module
Projects
None yet
Development

No branches or pull requests

2 participants