Remove IDatabaseContainer from LocalStackContainer and WebDriverConta…

…iner They aren't really databases.
testcontainers · Aug 31, 2023 · 3a88750 · 3a88750
1 parent ebc03d7
commit 3a88750
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/src/Testcontainers.LocalStack/LocalStackContainer.cs b/src/Testcontainers.LocalStack/LocalStackContainer.cs
@@ -2,7 +2,7 @@ namespace Testcontainers.LocalStack;
 
 /// <inheritdoc cref="DockerContainer" />
 [PublicAPI]
-public sealed class LocalStackContainer : DockerContainer, IDatabaseContainer
+public sealed class LocalStackContainer : DockerContainer
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="LocalStackContainer" /> class.

diff --git a/src/Testcontainers.WebDriver/WebDriverContainer.cs b/src/Testcontainers.WebDriver/WebDriverContainer.cs
@@ -2,7 +2,7 @@ namespace Testcontainers.WebDriver;
 
 /// <inheritdoc cref="DockerContainer" />
 [PublicAPI]
-public sealed class WebDriverContainer : DockerContainer, IDatabaseContainer
+public sealed class WebDriverContainer : DockerContainer
 {
     private readonly WebDriverConfiguration _configuration;
 

diff --git a/tests/Testcontainers.Databases.Tests/DatabasesContainerTest.cs b/tests/Testcontainers.Databases.Tests/DatabasesContainerTest.cs
@@ -9,6 +9,14 @@ public void ImplementsIDatabaseContainerInterface(Type type)
         Assert.True(type.IsAssignableTo(typeof(IDatabaseContainer)));
     }
 
+    private static readonly HashSet<Type> NotDatabaseContainerTypes = new()
+    {
+        typeof(LocalStack.LocalStackContainer),
+        typeof(WebDriver.WebDriverContainer),
+    };
+
+    private static bool IsDatabaseContainerType(Type containerType) => !NotDatabaseContainerTypes.Contains(containerType);
+
     public static IEnumerable<object[]> DatabaseContainersTheoryData
     {
         get
@@ -19,6 +27,7 @@ public static IEnumerable<object[]> DatabaseContainersTheoryData
             return dependencyContext.RuntimeLibraries
                 .Where(library => library.Name.StartsWith("Testcontainers."))
                 .SelectMany(library => Assembly.Load(library.Name).GetExportedTypes().Where(HasGetConnectionStringMethod))
+                .Where(IsDatabaseContainerType)
                 .Select(type => new[] { type });
         }
     }