Upgrade Go, Docker client and Alpine image #28
Conversation
* Upgrade Alpine 3.9.6 to 3.13.5 * Upgrade Docker 1.4.2 to 20.10.7 * Upgrade Go 1.13.3 to 1.16.5
could you please make sure that the API Version stays the same? |
|
I think this one should be merged before #40. I'd rebase my pull request then. |
|
I'm working on a PR that adds unit tests using testcontainers-go for creating containers and networks to be removed. In that branch the version of the Docker dependency has been bumped, so it will get into conflicts with this one. I think I'll send my PR today, so we will probably notify this PR with an update or even closing is as superseded |
| @@ -74,8 +74,8 @@ func processRequests(deathNote map[string]bool, firstConnected chan<- bool, wg * | |||
| panic(err) | |||
| } | |||
| log.Printf("New client connected: %s\n", conn.RemoteAddr().String()) | |||
| wg.Add(1) | |||
There was a problem hiding this comment.
Could you send this potential fix including explanation in a separate PR? 🙏
We are going to close this PR as the dependencies will be bumped in #46
|
Given #50 is merged, and in there we are bumping:
I'm closing this PR as obsolete. In any case, thanks for contributing to Ryuk! |
Trivy showed several problems in the container image and dependencies, so I upgraded everything.
You can integrate it into GitHub Actions if you want:
https://aquasecurity.github.io/trivy/latest/examples/report/#sarif