Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slow shutdown after signal #169

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

stevenh
Copy link
Contributor

@stevenh stevenh commented Oct 11, 2024

Fix shutdown after signal to allow the last client disconnect to trigger a prune check. Previous this would always wait for the shutdown timeout, which by default is 10 minutes, resulting in an unnecessarily slow shutdown.

Fix shutdown after signal to allow the last client disconnect to trigger
a prune check. Previous this would always waiting for the shutdown timeout,
which by default is 10 minutes, resulting in an unnecessarily slow shutdown.
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya self-assigned this Oct 14, 2024
@mdelapenya mdelapenya added the bug An issue with the project label Oct 14, 2024
@mdelapenya mdelapenya merged commit cbdc142 into testcontainers:main Oct 14, 2024
9 checks passed
@stevenh stevenh deleted the fix/slow-shutdown branch October 14, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants