Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test for kebab render log] Update computeRPCommon.json #3321

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JackTn
Copy link

@JackTn JackTn commented Apr 24, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app-test bot commented Apr 24, 2024

Next Steps to merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has at least one breaking change (label: BreakingChangeReviewRequired). See the PR description for help.
  • ❌ The required check named Swagger BreakingChange has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 1 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app-test bot commented Apr 24, 2024

Swagger Generation Artifacts

️🔄[ignore this check status; not blocking PR merge] ApiDocPreview inProgress [Detail]
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed in generating from 8bb7905e12b6a1291a684e9a0b62a4c1b93834d3. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
  • Azure.ResourceManager.Compute [Preview SDK Changes]
    info	[Changelog]
️❌ azure-sdk-for-python failed [Detail]
  • Code Generator Failed in generating from 8bb7905e12b6a1291a684e9a0b62a4c1b93834d3. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New patch version of npm available! 10.5.0 -> 10.5.2
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.5.2` to update!
    cmderr	[automation_generate.sh] npm notice
    cmdout	[automation_generate.sh] [Autorest]   | info:  Step: Fetching packages
    cmdout	[automation_generate.sh] [Autorest]   | error: @azure/logger@1.1.2: The engine "node" is incompatible with this module. Expected version ">=18.0.0". Got "16.15.0"
    cmdout	[automation_generate.sh] [Autorest]   | error: Found incompatible module.
    cmdout	[automation_generate.sh] [Autorest]   | info: Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
    cmdout	[automation_generate.sh] [Autorest]
    cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
    cmdout	[automation_generate.sh] [Autorest] fatal   | Failed to install extension '@autorest/python' (6.7.1)
    cmdout	[automation_generate.sh] [Autorest]   | info:  Step: Fetching packages
    cmdout	[automation_generate.sh] [Autorest]   | error: @azure/logger@1.1.2: The engine "node" is incompatible with this module. Expected version ">=18.0.0". Got "16.15.0"
    cmdout	[automation_generate.sh] [Autorest]   | error: Found incompatible module.
    cmdout	[automation_generate.sh] [Autorest]   | info: Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.
    cmdout	[automation_generate.sh] [Autorest]
    cmdout	[automation_generate.sh] [Autorest] error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.
    cmdout	[automation_generate.sh] [Autorest] fatal   | Failed to install extension '@autorest/python' (6.7.1)
    cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
    warn	Skip package processing as generation is failed
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning in generating from 8bb7905e12b6a1291a684e9a0b62a4c1b93834d3. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh]  notice
    cmderr	[init.sh] npm notice New patch version of npm available! 10.5.0 -> 10.5.2
    cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
    cmderr	[init.sh] npm notice Run `npm install -g npm@10.5.2` to update!
    cmderr	[init.sh] npm notice
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-compute-generated [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
    • azure-resourcemanager-compute-generated-1.0.0-beta.1-sources.jar
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 8bb7905e12b6a1291a684e9a0b62a4c1b93834d3. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-compute [Preview SDK Changes] Breaking Change Detected
    • azure-arm-compute-22.0.0.tgz
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added Interface EventGridAndResourceGraph
    info	[Changelog]   - Added Interface ScheduledEventsAdditionalPublishingTargets
    info	[Changelog]   - Added Interface ScheduledEventsPolicy
    info	[Changelog]   - Added Interface UserInitiatedReboot
    info	[Changelog]   - Added Interface UserInitiatedRedeploy
    info	[Changelog]   - Added Type Alias ResourceIdOptionsForGetCapacityReservationGroups
    info	[Changelog]   - Interface CapacityReservationGroupsListBySubscriptionOptionalParams has a new optional parameter resourceIdsOnly
    info	[Changelog]   - Interface DataDisk has a new optional parameter sourceResource
    info	[Changelog]   - Interface DataDisksToAttach has a new optional parameter caching
    info	[Changelog]   - Interface DataDisksToAttach has a new optional parameter deleteOption
    info	[Changelog]   - Interface DataDisksToAttach has a new optional parameter diskEncryptionSet
    info	[Changelog]   - Interface DataDisksToAttach has a new optional parameter writeAcceleratorEnabled
    info	[Changelog]   - Interface VirtualMachine has a new optional parameter scheduledEventsPolicy
    info	[Changelog]   - Interface VirtualMachineScaleSet has a new optional parameter scheduledEventsPolicy
    info	[Changelog]   - Interface VirtualMachineScaleSetUpdateOSDisk has a new optional parameter diffDiskSettings
    info	[Changelog]   - Interface VirtualMachineScaleSetVMReimageParameters has a new optional parameter forceUpdateOSDiskForEphemeral
    info	[Changelog]   - Interface VirtualMachineUpdate has a new optional parameter scheduledEventsPolicy
    info	[Changelog]   - Added Enum KnownResourceIdOptionsForGetCapacityReservationGroups
    info	[Changelog]   - Enum KnownDiffDiskPlacement has a new value NvmeDisk
    info	[Changelog]   - Enum KnownDiskCreateOptionTypes has a new value Copy
    info	[Changelog]   - Enum KnownDiskCreateOptionTypes has a new value Restore
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Removed operation group Operations
    info	[Changelog]   - Class ComputeManagementClient no longer has parameter operations
    Present SDK breaking changes suppressions
    No suppression file added.
    Absent SDK breaking changes suppressions
    - Class ComputeManagementClient no longer has parameter operations
    - Removed operation group Operations
    Parse Suppression File Errors
    No suppression file added.
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 8bb7905e12b6a1291a684e9a0b62a4c1b93834d3. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/compute/armcompute [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Type of `CloudServiceExtensionProperties.ProtectedSettings` has been changed from `any` to `interface{}`
    info	[Changelog] - Type of `CloudServiceExtensionProperties.Settings` has been changed from `any` to `interface{}`
    info	[Changelog] - Type of `VirtualMachineCaptureResult.Resources` has been changed from `[]any` to `[]interface{}`
    info	[Changelog] - Type of `VirtualMachineCaptureResult.Parameters` has been changed from `any` to `interface{}`
    info	[Changelog] - Type of `VirtualMachineExtensionProperties.Settings` has been changed from `any` to `interface{}`
    info	[Changelog] - Type of `VirtualMachineExtensionProperties.ProtectedSettings` has been changed from `any` to `interface{}`
    info	[Changelog] - Type of `VirtualMachineExtensionUpdateProperties.Settings` has been changed from `any` to `interface{}`
    info	[Changelog] - Type of `VirtualMachineExtensionUpdateProperties.ProtectedSettings` has been changed from `any` to `interface{}`
    info	[Changelog] - Type of `VirtualMachineScaleSetExtensionProperties.Settings` has been changed from `any` to `interface{}`
    info	[Changelog] - Type of `VirtualMachineScaleSetExtensionProperties.ProtectedSettings` has been changed from `any` to `interface{}`
    info	[Changelog] - Function `NewClientFactory` has been removed
    info	[Changelog] - Function `*ClientFactory.NewAvailabilitySetsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewCapacityReservationGroupsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewCapacityReservationsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewCloudServiceOperatingSystemsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewCloudServiceRoleInstancesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewCloudServiceRolesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewCloudServicesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewCloudServicesUpdateDomainClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewCommunityGalleriesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewCommunityGalleryImageVersionsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewCommunityGalleryImagesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewDedicatedHostGroupsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewDedicatedHostsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewDiskAccessesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewDiskEncryptionSetsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewDiskRestorePointClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewDisksClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewGalleriesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewGalleryApplicationVersionsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewGalleryApplicationsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewGalleryImageVersionsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewGalleryImagesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewGallerySharingProfileClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewImagesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewLogAnalyticsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewOperationsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewProximityPlacementGroupsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewResourceSKUsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewRestorePointCollectionsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewRestorePointsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewSSHPublicKeysClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewSharedGalleriesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewSharedGalleryImageVersionsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewSharedGalleryImagesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewSnapshotsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewUsageClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewVirtualMachineExtensionImagesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewVirtualMachineExtensionsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewVirtualMachineImagesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewVirtualMachineImagesEdgeZoneClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewVirtualMachineRunCommandsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewVirtualMachineScaleSetExtensionsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewVirtualMachineScaleSetRollingUpgradesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewVirtualMachineScaleSetVMExtensionsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewVirtualMachineScaleSetVMRunCommandsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewVirtualMachineScaleSetVMsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewVirtualMachineScaleSetsClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewVirtualMachineSizesClient` has been removed
    info	[Changelog] - Function `*ClientFactory.NewVirtualMachinesClient` has been removed
    info	[Changelog] - Function `NewOperationsClient` has been removed
    info	[Changelog] - Function `*OperationsClient.NewListPager` has been removed
    info	[Changelog] - Function `dateTimeRFC3339.MarshalText` has been removed
    info	[Changelog] - Function `*dateTimeRFC3339.Parse` has been removed
    info	[Changelog] - Function `dateTimeRFC3339.String` has been removed
    info	[Changelog] - Function `*dateTimeRFC3339.UnmarshalText` has been removed
    info	[Changelog] - Struct `ClientFactory` has been removed
    info	[Changelog] - Struct `OperationsClientListResponse` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New function `timeRFC3339.MarshalText() ([]byte, error)`
    info	[Changelog] - New function `*timeRFC3339.Parse(string) error`
    info	[Changelog] - New function `*timeRFC3339.UnmarshalText([]byte) error`
    info	[Changelog]
    info	[Changelog] Total 65 breaking change(s), 3 additive change(s).
    Present SDK breaking changes suppressions
    No suppression file added.
    Absent SDK breaking changes suppressions
    - Function `*ClientFactory.NewAvailabilitySetsClient` has been removed
    - Function `*ClientFactory.NewCapacityReservationGroupsClient` has been removed
    - Function `*ClientFactory.NewCapacityReservationsClient` has been removed
    - Function `*ClientFactory.NewCloudServiceOperatingSystemsClient` has been removed
    - Function `*ClientFactory.NewCloudServiceRoleInstancesClient` has been removed
    - Function `*ClientFactory.NewCloudServiceRolesClient` has been removed
    - Function `*ClientFactory.NewCloudServicesClient` has been removed
    - Function `*ClientFactory.NewCloudServicesUpdateDomainClient` has been removed
    - Function `*ClientFactory.NewCommunityGalleriesClient` has been removed
    - Function `*ClientFactory.NewCommunityGalleryImageVersionsClient` has been removed
    - Function `*ClientFactory.NewCommunityGalleryImagesClient` has been removed
    - Function `*ClientFactory.NewDedicatedHostGroupsClient` has been removed
    - Function `*ClientFactory.NewDedicatedHostsClient` has been removed
    - Function `*ClientFactory.NewDiskAccessesClient` has been removed
    - Function `*ClientFactory.NewDiskEncryptionSetsClient` has been removed
    - Function `*ClientFactory.NewDiskRestorePointClient` has been removed
    - Function `*ClientFactory.NewDisksClient` has been removed
    - Function `*ClientFactory.NewGalleriesClient` has been removed
    - Function `*ClientFactory.NewGalleryApplicationVersionsClient` has been removed
    - Function `*ClientFactory.NewGalleryApplicationsClient` has been removed
    - Function `*ClientFactory.NewGalleryImageVersionsClient` has been removed
    - Function `*ClientFactory.NewGalleryImagesClient` has been removed
    - Function `*ClientFactory.NewGallerySharingProfileClient` has been removed
    - Function `*ClientFactory.NewImagesClient` has been removed
    - Function `*ClientFactory.NewLogAnalyticsClient` has been removed
    - Function `*ClientFactory.NewOperationsClient` has been removed
    - Function `*ClientFactory.NewProximityPlacementGroupsClient` has been removed
    - Function `*ClientFactory.NewResourceSKUsClient` has been removed
    - Function `*ClientFactory.NewRestorePointCollectionsClient` has been removed
    - Function `*ClientFactory.NewRestorePointsClient` has been removed
    - Function `*ClientFactory.NewSSHPublicKeysClient` has been removed
    - Function `*ClientFactory.NewSharedGalleriesClient` has been removed
    - Function `*ClientFactory.NewSharedGalleryImageVersionsClient` has been removed
    - Function `*ClientFactory.NewSharedGalleryImagesClient` has been removed
    - Function `*ClientFactory.NewSnapshotsClient` has been removed
    - Function `*ClientFactory.NewUsageClient` has been removed
    - Function `*ClientFactory.NewVirtualMachineExtensionImagesClient` has been removed
    - Function `*ClientFactory.NewVirtualMachineExtensionsClient` has been removed
    - Function `*ClientFactory.NewVirtualMachineImagesClient` has been removed
    - Function `*ClientFactory.NewVirtualMachineImagesEdgeZoneClient` has been removed
    - Function `*ClientFactory.NewVirtualMachineRunCommandsClient` has been removed
    - Function `*ClientFactory.NewVirtualMachineScaleSetExtensionsClient` has been removed
    - Function `*ClientFactory.NewVirtualMachineScaleSetRollingUpgradesClient` has been removed
    - Function `*ClientFactory.NewVirtualMachineScaleSetVMExtensionsClient` has been removed
    - Function `*ClientFactory.NewVirtualMachineScaleSetVMRunCommandsClient` has been removed
    - Function `*ClientFactory.NewVirtualMachineScaleSetVMsClient` has been removed
    - Function `*ClientFactory.NewVirtualMachineScaleSetsClient` has been removed
    - Function `*ClientFactory.NewVirtualMachineSizesClient` has been removed
    - Function `*ClientFactory.NewVirtualMachinesClient` has been removed
    - Function `*OperationsClient.NewListPager` has been removed
    - Function `*dateTimeRFC3339.Parse` has been removed
    - Function `*dateTimeRFC3339.UnmarshalText` has been removed
    - Function `NewClientFactory` has been removed
    - Function `NewOperationsClient` has been removed
    - Function `dateTimeRFC3339.MarshalText` has been removed
    - Function `dateTimeRFC3339.String` has been removed
    - Struct `ClientFactory` has been removed
    - Struct `OperationsClientListResponse` has been removed
    - Type of `CloudServiceExtensionProperties.ProtectedSettings` has been changed from `any` to `interface{}`
    - Type of `CloudServiceExtensionProperties.Settings` has been changed from `any` to `interface{}`
    - Type of `VirtualMachineCaptureResult.Parameters` has been changed from `any` to `interface{}`
    - Type of `VirtualMachineCaptureResult.Resources` has been changed from `[]any` to `[]interface{}`
    - Type of `VirtualMachineExtensionProperties.ProtectedSettings` has been changed from `any` to `interface{}`
    - Type of `VirtualMachineExtensionProperties.Settings` has been changed from `any` to `interface{}`
    - Type of `VirtualMachineExtensionUpdateProperties.ProtectedSettings` has been changed from `any` to `interface{}`
    - Type of `VirtualMachineExtensionUpdateProperties.Settings` has been changed from `any` to `interface{}`
    - Type of `VirtualMachineScaleSetExtensionProperties.ProtectedSettings` has been changed from `any` to `interface{}`
    - Type of `VirtualMachineScaleSetExtensionProperties.Settings` has been changed from `any` to `interface{}`
    Parse Suppression File Errors
    No suppression file added.
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️❌ azure-resource-manager-schemas failed [Detail]
  • Failed in generating from 8bb7905e12b6a1291a684e9a0b62a4c1b93834d3. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]  notice
    cmderr	[initScript.sh] npm notice New patch version of npm available! 10.5.0 -> 10.5.2
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.2>
    cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.5.2` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] WARNING: Unable to parse swagger path "Microsoft.Compute/common-types/v1/common.json"
  • compute/resource-manager [Preview Schema Changes]
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from 8bb7905e12b6a1291a684e9a0b62a4c1b93834d3. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.compute.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app-test bot commented Apr 24, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/compute/armcompute Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).
Java azure-resourcemanager-compute-generated Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).
JavaScript @azure/arm-compute Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).
Swagger Microsoft.Compute Create ApiView failed. To get help, please see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).

Copy link

openapi-pipeline-app-test bot commented Apr 24, 2024

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.8) new version base version
computeRPCommon.json 2024-03-01(7d07e82) 2024-03-01(main)
Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.Compute/operations' removed or restructured?
Old: ComputeRP/stable/2024-03-01/computeRPCommon.json#L37:5
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.0) new version base version
package-2024-03-01 package-2024-03-01(7d07e82) package-2024-03-01(main)

The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.

Rule Message
GetCollectionResponseSchema The response in the GET collection operation 'VirtualMachineRunCommands_List' does not match the response definition in the individual GET operation 'VirtualMachineRunCommands_Get' .
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L36
GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L113
MissingTypeObject The schema 'ComputeOperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L139
MissingTypeObject The schema 'ComputeOperationValue' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L155
MissingTypeObject The schema 'ComputeOperationValueDisplay' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L174
MissingTypeObject The schema 'UsageName' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L199
MissingTypeObject The schema 'Usage' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L212
MissingTypeObject The schema 'ListUsagesResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L248
MissingTypeObject The schema 'SubResourceWithColocationStatus' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L316
MissingTypeObject The schema 'VirtualMachineSize' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L330
MissingTypeObject The schema 'VirtualMachineSizeListResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L364
MissingTypeObject The schema 'Plan' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L379
MissingTypeObject The schema 'HardwareProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L400
MissingTypeObject The schema 'ImageReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L658
MissingTypeObject The schema 'KeyVaultSecretReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L709
MissingTypeObject The schema 'KeyVaultKeyReference' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L735
MissingTypeObject The schema 'DiskEncryptionSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L752
MissingTypeObject The schema 'VirtualHardDisk' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L792
MissingTypeObject The schema 'DiffDiskSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L893
MissingTypeObject The schema 'ManagedDiskParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L906
MissingTypeObject The schema 'OSDisk' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L928
MissingTypeObject The schema 'DataDisk' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L993
MissingTypeObject The schema 'StorageProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L1078
MissingTypeObject The schema 'UefiSettings' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L1105
MissingTypeObject The schema 'SecurityProfile' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L1155
MissingTypeObject The schema 'AdditionalCapabilities' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L1238
MissingTypeObject The schema 'AdditionalUnattendContent' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L1251
MissingTypeObject The schema 'WinRMListener' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L1294
MissingTypeObject The schema 'WinRMConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L1315
MissingTypeObject The schema 'WindowsConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: ComputeRP/stable/2024-03-01/computeRPCommon.json#L1328
️️✔️[ignore this check status; not blocking PR merge] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌Avocado: 3 Errors, 1 Warnings failed [Detail]
Rule Message
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/compute/resource-manager/readme.md
json: 2024-03-01/examples/computeRPCommonExamples/Operations_List_MaximumSet_Gen.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/compute/resource-manager/readme.md
json: 2024-03-01/examples/computeRPCommonExamples/Operations_List_MinimumSet_Gen.json
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /providers/Microsoft.Compute/operations is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/compute/resource-manager/readme.md
json: ComputeRP/stable/2023-09-01/computeRPCommon.json
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/compute/resource-manager/readme.md
tag: specification/compute/resource-manager/readme.md#tag-package-2024-03-01
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[ignore this check status; not blocking PR merge] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants