forked from Azure/azure-rest-api-specs
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for CallAutomation to add version preview/2022-04-07-preview #2958
Open
praveenkuttappan
wants to merge
2
commits into
main
Choose a base branch
from
praveenkuttappan-communication-CallAutomation-2022-04-07-preview
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Hub Generated] Review request for CallAutomation to add version preview/2022-04-07-preview #2958
praveenkuttappan
wants to merge
2
commits into
main
from
praveenkuttappan-communication-CallAutomation-2022-04-07-preview
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
Compared specs (v0.10.8) | new version | base version |
---|---|---|
communicationservicescallautomation.json | 2022-04-07-preview(0aa4732) | 2022-04-07-preview(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️
LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.0) | new version | base version |
---|---|---|
package-2022-04-07-preview | package-2022-04-07-preview(0aa4732) | package-2022-04-07-preview(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
LroExtension |
Operations with a 202 response must specify x-ms-long-running-operation: true . GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be definedLocation: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L364 |
LroExtension |
Operations with a 202 response must specify x-ms-long-running-operation: true . GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be definedLocation: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L427 |
LroExtension |
Operations with a 202 response must specify x-ms-long-running-operation: true . GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be definedLocation: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L474 |
LroExtension |
Operations with a 202 response must specify x-ms-long-running-operation: true . GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be definedLocation: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L512 |
LroExtension |
Operations with a 202 response must specify x-ms-long-running-operation: true . GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be definedLocation: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L600 |
LroExtension |
Operations with a 202 response must specify x-ms-long-running-operation: true . GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be definedLocation: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L663 |
LroExtension |
Operations with a 202 response must specify x-ms-long-running-operation: true . GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be definedLocation: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L904 |
LroExtension |
Operations with a 202 response must specify x-ms-long-running-operation: true . GET operation is excluded from the validation as GET will have 202 only if it is a polling action & hence x-ms-long-running-operation wouldn't be definedLocation: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L941 |
The summary and description values should not be same. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L19 |
|
header parameter name 'Repeatability-Request-ID' should be kebab case. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L40 |
|
Error response should contain a x-ms-error-code header. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L54 |
|
Error schema should define code and message properties as required.Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L56 |
|
Using post for a create operation is discouraged. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L60 |
|
header parameter name 'Repeatability-Request-ID' should be kebab case. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L96 |
|
Error response should contain a x-ms-error-code header. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L110 |
|
Error schema should define code and message properties as required.Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L112 |
|
The summary and description values should not be same. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L131 |
|
header parameter name 'Repeatability-Request-ID' should be kebab case. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L152 |
|
Error response should contain a x-ms-error-code header. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L166 |
|
Error schema should define code and message properties as required.Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L168 |
|
The summary and description values should not be same. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L184 |
|
header parameter name 'Repeatability-Request-ID' should be kebab case. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L205 |
|
Error response should contain a x-ms-error-code header. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L219 |
|
Error schema should define code and message properties as required.Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L221 |
|
Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L244 |
|
Error response should contain a x-ms-error-code header. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L256 |
|
Error schema should define code and message properties as required.Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L258 |
|
The summary and description values should not be same. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L275 |
|
'DELETE' operation 'CallConnections_HangupCall' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L281 |
|
OperationId for delete method should contain 'Delete' Location: CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json#L281 |
️️✔️
[ignore this check status; not blocking PR merge] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
[ignore this check status; not blocking PR merge] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Hi, @praveenkuttappan! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Generation Artifacts
|
Generated ApiView
|
openapi-dev-app-company2
bot
commented
Jan 24, 2024
•
edited by openapi-pipeline-app-test
bot
Loading
edited by openapi-pipeline-app-test
bot
Next Steps to MergeNext steps that must be taken to merge this PR:
|
/azp run |
There was an error handling pipeline event 5aabf1a8-f956-42d8-8fd1-b78cf7f984bf. The command could not be run. |
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
...ata-plane/CallAutomation/preview/2022-04-07-preview/communicationservicescallautomation.json
Outdated
Show resolved
Hide resolved
…2022-04-07-preview/communicationservicescallautomation.json
This was referenced Jul 25, 2024
This was referenced Oct 23, 2024
Open
Open
Open
Open
This was referenced Nov 27, 2024
This was referenced Dec 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Data Plane API - Pull Request
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
fix #3025
fix #3026
fix #3027
fix azure-sdk/TestingForEngagementExperience#321
fix azure-sdk/TestingForEngagementExperience#325
fix azure-sdk/TestingForEngagementExperience#334