Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base provisioner refactoring #298

Merged
merged 11 commits into from
Dec 20, 2013
Merged

Base provisioner refactoring #298

merged 11 commits into from
Dec 20, 2013

Commits on Dec 20, 2013

  1. Formatting.

    @fnichol
    fnichol committed Dec 20, 2013
    Configuration menu
    Copy the full SHA
    311c288 View commit details
    Browse the repository at this point in the history

  2. [provisioner/shell] Refactorings to duplicate useful logic from Chef*. 

    This work should lead directly to a refactoring of
`Kitchen::Provisioner::Base` with logic from
`Kitchen::Provisioner::ChefBase`.
    @fnichol
    fnichol committed Dec 20, 2013
    Configuration menu
    Copy the full SHA
    bf2a082 View commit details
    Browse the repository at this point in the history

  3. Remove sandbox debugging in Driver::SSHBase.

    @fnichol
    fnichol committed Dec 20, 2013
    Configuration menu
    Copy the full SHA
    8f52478 View commit details
    Browse the repository at this point in the history

  4. Expose Provisioner#sandbox_path for use by drivers & remove tmpdir. 

    This commit changes the behavior of `Provisioner#create_sandbox` in that
it no longer returns the created sandbox path. Now the expected calling
behavior is to call `Provisioner#create_sandbox` and then refer to the
sandbox path with `Provisioner#sandbox_path`. This allows
`#create_sandbox` to make use of calls to super in a clean way and to
decouple the command and query nature of this method.
    @fnichol
    fnichol committed Dec 20, 2013
    Configuration menu
    Copy the full SHA
    4effec0 View commit details
    Browse the repository at this point in the history

  5. Extract #create_sandbox & #cleanup_sandbox code to Provisioner::Base.

    @fnichol
    fnichol committed Dec 20, 2013
    Configuration menu
    Copy the full SHA
    0b2a6a0 View commit details
    Browse the repository at this point in the history

  6. Extract #calculate_path to Provisioner::Base as common provisioner lo… 

    …gic.
    @fnichol
    fnichol committed Dec 20, 2013
    Configuration menu
    Copy the full SHA
    7bdd514 View commit details
    Browse the repository at this point in the history

  7. Add expand_path_for class method in Provisioner::Base for provisioners. 

    This is a declarative way, similar to declaring default_config, to have
certain config values be path expanded. This helps when debugging using
`kitchen diganose` and leaves local paths unambiguous as to the source
location.

In general, all local config-related paths and files should be path
expanded.
    @fnichol
    fnichol committed Dec 20, 2013
    Configuration menu
    Copy the full SHA
    1bc1d23 View commit details
    Browse the repository at this point in the history

  8. Update config[:file] to config[:script] & refactor code.

    @fnichol
    fnichol committed Dec 20, 2013
    Configuration menu
    Copy the full SHA
    6c810e7 View commit details
    Browse the repository at this point in the history

  9. Add a data_path to Provisioner::Shell.

    @fnichol
    fnichol committed Dec 20, 2013
    Configuration menu
    Copy the full SHA
    cda9139 View commit details
    Browse the repository at this point in the history

  10. Re-order methods in Provisioner::Base.

    @fnichol
    fnichol committed Dec 20, 2013
    Configuration menu
    Copy the full SHA
    e07d14d View commit details
    Browse the repository at this point in the history

  11. Update class comment in Kitchen::Provisioner::Shell. 

    Thanks to @juliandunn for the catch :)
    @fnichol
    fnichol committed Dec 20, 2013
    Configuration menu
    Copy the full SHA
    3c63639 View commit details
    Browse the repository at this point in the history