WIP: Adding technical reviews / target list summaries to tessproposaltool #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xist and not re-run a technical_review, updated technical_review to save a flag summary
|
@tylerapritchard is this still a WIP or do we think tests could pass and we could merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new set of features that involves performing a number of checks on a given set of TIC IDs, and having the framework for technical reviews, where given a list of proposals and TIC IDs from the proposal target lists we can check the brightness and observability of the targets, and write convenient summaries/plots.
This is currently a work in progress, things that are still needed: