-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more clone benchmarks #998
Add more clone benchmarks #998
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #998 +/- ##
==========================================
- Coverage 90.17% 90.16% -0.02%
==========================================
Files 280 280
Lines 15701 15701
==========================================
- Hits 14159 14157 -2
- Misses 1542 1544 +2 |
@johnwason Do you know why everything for windows, conda and mac os is failing now? Everything passed in the latest MR that was merged. |
I am not seeing errors locally. I will check on github actions and see if I can capture more data. |
Apparently this is a problem with CMake 3.29.1 |
I am testing adding this step before vcpkg and build steps:
|
Changing the cmake version worked. https://github.com/johnwason/tesseract/actions/runs/8656859533/job/23738056581 The error is from my artifact capturing, the build did work. |
@johnwason Can this also be used to fix the conda builds? |
3a342c2
into
tesseract-robotics:master
It looks like changing the cmake version fixed the windows builds, but still need to figure out mac and conda build issue. |
No description provided.