Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more clone benchmarks #998

Conversation

Levi-Armstrong
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (ea3d5c3) to head (ca24a62).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #998      +/-   ##
==========================================
- Coverage   90.17%   90.16%   -0.02%     
==========================================
  Files         280      280              
  Lines       15701    15701              
==========================================
- Hits        14159    14157       -2     
- Misses       1542     1544       +2     

see 2 files with indirect coverage changes

@Levi-Armstrong
Copy link
Contributor Author

@johnwason Do you know why everything for windows, conda and mac os is failing now? Everything passed in the latest MR that was merged.

@johnwason
Copy link
Contributor

I am not seeing errors locally. I will check on github actions and see if I can capture more data.

@johnwason
Copy link
Contributor

See microsoft/vcpkg#38140

@johnwason
Copy link
Contributor

Apparently this is a problem with CMake 3.29.1

microsoft/vcpkg#37968

@johnwason
Copy link
Contributor

I am testing adding this step before vcpkg and build steps:

   - name: Setup cmake
      uses: jwlawson/actions-setup-cmake@v2
      with:
        cmake-version: '3.28.x'

@johnwason
Copy link
Contributor

Changing the cmake version worked. https://github.com/johnwason/tesseract/actions/runs/8656859533/job/23738056581

The error is from my artifact capturing, the build did work.

@Levi-Armstrong
Copy link
Contributor Author

@johnwason Can this also be used to fix the conda builds?

@Levi-Armstrong Levi-Armstrong merged commit 3a342c2 into tesseract-robotics:master Apr 15, 2024
11 of 13 checks passed
@Levi-Armstrong Levi-Armstrong deleted the feature/more-benchmarks branch April 15, 2024 13:02
@Levi-Armstrong
Copy link
Contributor Author

It looks like changing the cmake version fixed the windows builds, but still need to figure out mac and conda build issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants