-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trajectory player fixes #989
Merged
Levi-Armstrong
merged 4 commits into
tesseract-robotics:master
from
rjoomen:trajectoryfix
Feb 21, 2024
Merged
Trajectory player fixes #989
Levi-Armstrong
merged 4 commits into
tesseract-robotics:master
from
rjoomen:trajectoryfix
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0, e.g. when in a trajectory set - Fix trajectory interpolator for size=1 trajectories
This is working for me and is definitely a nice addition, just have a couple of notes:
|
rjoomen
added a commit
to rjoomen/tesseract_planning
that referenced
this pull request
Feb 20, 2024
|
Levi-Armstrong
requested changes
Feb 20, 2024
- Fixed a bug in the trajectory interpolator - Renamed parameter t to f in the interpolator, as this is a fraction (blend), not time, to prevent confusion
rjoomen
force-pushed
the
trajectoryfix
branch
from
February 21, 2024 09:15
f9a2bbd
to
ff2da54
Compare
Levi-Armstrong
approved these changes
Feb 21, 2024
Levi-Armstrong
merged commit Feb 21, 2024
7a971fb
into
tesseract-robotics:master
11 of 13 checks passed
rjoomen
added a commit
to rjoomen/tesseract_planning
that referenced
this pull request
Feb 22, 2024
Levi-Armstrong
pushed a commit
to tesseract-robotics/tesseract_planning
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to tesseract-robotics/tesseract_qt#99.