Add Mac OSX support #969
Merged
Add Mac OSX support #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #969 +/- ##
==========================================
- Coverage 90.93% 90.93% -0.01%
==========================================
Files 280 280
Lines 15851 15847 -4
==========================================
- Hits 14414 14410 -4
Misses 1437 1437 |
|
@johnwason Let me know when this is ready to review. I think it would be good to leverage the colcon-build action and update it to support MacOS. |
|
@Levi-Armstrong sure, sounds good. I am getting lots of errors on CI that I am not getting locally so it may take some time to figure out. |
|
Once you get your version of mac os CI build working I can port what is needed to colcon-build action. |
|
The conda build failure is unrelated to this PR. This is ready to merge. |
Levi-Armstrong
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains patches and a GitHub build action for Mac OSX.