Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows updates #893

Merged
merged 7 commits into from
May 23, 2023
Merged

Windows updates #893

merged 7 commits into from
May 23, 2023

Conversation

johnwason
Copy link
Contributor

This pull request has a few Windows fixes:

  • Include Bcrypt as a default library on Win32 builds
  • Use Eigen Index types instead of long when doing computations on Eigen indexs
  • Add windows-2022 CI test build

Levi-Armstrong
Levi-Armstrong requested changes May 23, 2023
View reviewed changes
Copy link
Contributor

@Levi-Armstrong Levi-Armstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use Eigen::Index instead of tesseract_common::TrajArray::Index for readability?

tesseract_common/CMakeLists.txt Show resolved Hide resolved
@johnwason
Copy link
Contributor Author

No it only exists as part of a template

@Levi-Armstrong Levi-Armstrong merged commit 2a50d0f into tesseract-robotics:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Levi-Armstrong Levi-Armstrong Levi-Armstrong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnwason @Levi-Armstrong