Use ROS-independent version of ICI #861
Conversation
marip8
force-pushed
the
update/ros-independent-ci
branch
from
7147533 to
28872f2
Compare
marip8
force-pushed
the
update/ros-independent-ci
branch
from
7a1b598 to
7ebc100
Compare
|
It looks like the Focal builds are failing on the octomap unit test due to the issue documented in #828. Also the Bionic build can't find |
|
It does not look like the libraries are provided on 18.04. I am fine with removing this CI build because it will be EOL in April. |
marip8
force-pushed
the
update/ros-independent-ci
branch
from
c6124c1 to
eac0580
Compare
marip8
force-pushed
the
update/ros-independent-ci
branch
from
9f03e8f to
d571660
Compare
|
I merged a few of the jobs together to reduce code duplication. It's set up now to run all Ubuntu and Windows jobs in a matrix to support the same build steps for multiple distributions. I also merged the two code quality jobs (code coverage and clang tidy) in a matrix. It was getting difficult to make sure all the variables were set correctly, so this should help make introducing jobs for new distros easier |
|
Looks good! |
|
Looks like something is wrong with the Windows build since it's failed the last couple of merged PRs, but this PR should be ready for review now |
|
Windows is failing because I updated the ros_industrial_cmake_bolilerplate version and it no longer can find gtest. |
|
Should we revert to 0.3.x then? That would allow us to reintroduce the bionic build as well which some people might appreciate |
|
I would just add gtest to the vcpkg list |
That apparently doesn't work, unless it's under a different name than |
Need to add |
|
Ah my mistake; was stuck on RICB for some reason |
|
The issue now is that octomap repository is to being build first. I not sure why but it could be because it has a top level CMakeLists.txt file and colcon is not searching deeper to the sub directories which have a package.xml. |
|
I would just add a separate rosinstall file for windows and remove fcl and octomap. Then add fcl and octomap back to vcpkg list. |
|
LGTM, I recommend squash merging this when you are ready |
Changes per commit message to address #834