Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker push #685

Merged

Conversation

Levi-Armstrong
Copy link
Contributor

@Levi-Armstrong
Copy link
Contributor Author

@marip8 The issue I believe is that this is ${{ steps.meta.outputs.tags }} is now a list and running docker push on this variable it fails. I made a change in this PR but not sure how best to test it without merging. How did you originally test this?

@marip8
Copy link
Contributor

marip8 commented Dec 15, 2021

I see. I've never had more than one tag be active at a time, so I hadn't run into this yet. I tested by opening a PR against my fork of the repository and merging it into my fork's master branch

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #685 (62864c0) into master (9472545) will not change coverage.
The diff coverage is n/a.

❗ Current head 62864c0 differs from pull request most recent head 2f6f1dc. Consider uploading reports for the commit 2f6f1dc to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #685   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files         172      172           
  Lines       10881    10881           
=======================================
  Hits        10050    10050           
  Misses        831      831           

@Levi-Armstrong Levi-Armstrong merged commit 488247a into tesseract-robotics:master Dec 15, 2021
@Levi-Armstrong Levi-Armstrong deleted the update/DockerCreation branch December 15, 2021 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants