Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker creation for major.minor #683

Merged

Conversation

Levi-Armstrong
Copy link
Contributor

@Levi-Armstrong Levi-Armstrong commented Dec 15, 2021

Currently a docker is create for major.minor.patch but this also adds one with just major.minor which will be used for other CI pipelines to avoid having to frequently update other CI pipelines for patch versions.

Copy link
Contributor

@marip8 marip8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good and will make deployment and CI easier. We should be careful to follow semver rules closely though going forward; otherwise these tags and images won't have much meaning.

@Levi-Armstrong Levi-Armstrong merged commit ff3ea36 into tesseract-robotics:master Dec 15, 2021
@Levi-Armstrong Levi-Armstrong deleted the update/DockerCreation branch December 15, 2021 16:09
@Levi-Armstrong
Copy link
Contributor Author

@marip8 It looks like there is an issue with the push. I noticed in the documentation they using the following to push. Did you try this originally and it did not work?

-
        name: Build and push
        uses: docker/build-push-action@v2
        with:
          context: .
          push: ${{ github.event_name != 'pull_request' }}
          tags: ${{ steps.meta.outputs.tags }}
          labels: ${{ steps.meta.outputs.labels }}

@marip8
Copy link
Contributor

marip8 commented Dec 15, 2021

I was under the impression that the build-push-action actually builds a Docker image and then pushes that built image to some repository. I didn't think you could skip the build step, but I didn't look into it very deeply since the push aspect is a one-line call: docker push .... What's the issue with the push?

@Levi-Armstrong
Copy link
Contributor Author

Yea you are correct.

@marip8
Copy link
Contributor

marip8 commented Dec 15, 2021

If you're wondering why release 0.7.3 didn't produce a docker image for the Bionic and Focal builds, it's because the docker meta-information extractor did not come up with any tag names based on the new pep440 rules

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants