Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geometry type CompoundMesh #1046

Conversation

Levi-Armstrong
Copy link
Contributor

@Levi-Armstrong Levi-Armstrong commented Sep 16, 2024

It is possible that a single resource can contain multiple meshes and currently these are added as separate geometries to a link and the association is lost for the most part. It is possible to loop over all geometries for a given link and check the if the resource are the same but this is not ideal. This simplifies things so all meshes for a single resource will be stored in a CompoundMesh if more than one mesh exists.

This was issue because in rviz and tesseract_qt_studio if a visual mesh was a dae file with multiple meshes it would load the full mesh file for every submesh stored resulting in multiple copies of the same mesh. This was causing performance issues during rendering. Having the compound mesh solves issue because all meshes for a given resource are stored together.

@Levi-Armstrong Levi-Armstrong force-pushed the feature/geometry-type-compound-mesh branch 2 times, most recently from 6a90096 to fc88c40 Compare September 16, 2024 21:17
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.43%. Comparing base (75cfd93) to head (ce20f46).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
- Coverage   89.53%   89.43%   -0.10%     
==========================================
  Files         285      288       +3     
  Lines       16003    16231     +228     
==========================================
+ Hits        14328    14517     +189     
- Misses       1675     1714      +39     

see 13 files with indirect coverage changes

@Levi-Armstrong Levi-Armstrong force-pushed the feature/geometry-type-compound-mesh branch 2 times, most recently from b495bdc to eb8661b Compare September 18, 2024 19:14
@Levi-Armstrong
Copy link
Contributor Author

@johnwason Do you have any ideas why the conda builds cannot locate resources in tesseract_support?

@Levi-Armstrong Levi-Armstrong force-pushed the feature/geometry-type-compound-mesh branch from eb8661b to 443bf07 Compare September 19, 2024 14:13
@Levi-Armstrong Levi-Armstrong force-pushed the feature/geometry-type-compound-mesh branch from 443bf07 to ce20f46 Compare September 19, 2024 15:47
@Levi-Armstrong Levi-Armstrong merged commit 4133b50 into tesseract-robotics:master Sep 19, 2024
13 of 15 checks passed
@Levi-Armstrong Levi-Armstrong deleted the feature/geometry-type-compound-mesh branch September 19, 2024 17:02
@johnwason
Copy link
Contributor

Sorry I missed this question. Did you get it working?

@Levi-Armstrong
Copy link
Contributor Author

Yea, I think I figured out the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants