Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary data serialization support functions #1002

Conversation

Levi-Armstrong
Copy link
Contributor

No description provided.

@Levi-Armstrong
Copy link
Contributor Author

@marip8, @marrts and @rjoomen These new utility function will allow us to update the ros messages to send binary data instead of xml string which is significantly smaller payload.

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (660d42d) to head (1aea690).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
+ Coverage   90.17%   90.19%   +0.01%     
==========================================
  Files         280      280              
  Lines       15753    15801      +48     
==========================================
+ Hits        14205    14251      +46     
- Misses       1548     1550       +2     

see 4 files with indirect coverage changes

@marrts
Copy link
Contributor

marrts commented May 29, 2024

I assume that also means save to files would be a lot smaller? That would be nice.

@Levi-Armstrong
Copy link
Contributor Author

I assume that also mean save to files would be a lot smaller? That would be nice.

Yea, those utilities already exist and are significantly smaller when saving to file.

@Levi-Armstrong Levi-Armstrong merged commit 371e7d5 into tesseract-robotics:master May 29, 2024
10 of 13 checks passed
@Levi-Armstrong Levi-Armstrong deleted the feature/serialize-to-binary-data branch May 29, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants