Use python script for generating list.eval and list.train. #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This decreases dependency on `bc` program and solves the problem with EOL on Windows.
stweil
requested changes
Mar 15, 2024
Comment on lines
+24
to
+28
| with open(train_list, 'w', newline='\n') as f1, open( | ||
| eval_list, 'w', newline='\n' | ||
| ) as f2: | ||
| f1.writelines(lines[:split_point]) | ||
| f2.writelines(lines[split_point:]) |
There was a problem hiding this comment.
Suggested change
| with open(train_list, 'w', newline='\n') as f1, open( | |
| eval_list, 'w', newline='\n' | |
| ) as f2: | |
| f1.writelines(lines[:split_point]) | |
| f2.writelines(lines[split_point:]) | |
| with open(train_list, 'w', newline='\n') as f: | |
| f.writelines(lines[:split_point]) | |
| with open(eval_list, 'w', newline='\n') as f: | |
| f.writelines(lines[split_point:]) |
There was a problem hiding this comment.
I think it looks simpler like that. Is there a reason to implement it differently?
There was a problem hiding this comment.
As far as I see modern examples and tutorials on the internet: if you open more files with with they are always combined into one as in my PR.
Also, python linters do not like single-letter (f) variables and for readability, I suggest using different names for eval and train files.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decreases dependency on
bcprogram and solves the problem with EOL on Windows.