Fix CMake install configs #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
This was referenced Oct 3, 2020
|
The path should be updated also in |
|
@yuriisk, sorry, don't get it. Could you explain where in this file the path should be updated? |
|
@Shatur95, This command |
|
@yuriisk, thanks, will send a PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CMake files are being installed in the
cmakefolder in the root of the install prefix. This is a bit odd. On Linux installation through CMake will createcmakein the/usr(common installation prefix on most distros), which is not desirable.Usually CMake files are installed to the
lib/cmakefolder and export files are installed to thelib/library-name. That's what I changed in this PR.