Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of single pages from multipage TIFF files (issue #2537) #2542

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Fix handling of single pages from multipage TIFF files (issue #2537) #2542

merged 2 commits into from
Jul 4, 2019

Conversation

stweil
Copy link
Member

@stweil stweil commented Jul 4, 2019

No description provided.

stweil added 2 commits July 4, 2019 15:44
@stweil
Revert "fix read wrong tiff page."
f1c6564 
This reverts commit 75d230a.

That commit introduced new problems (memory leak, potential endless loop)
and style issues.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@stweil
Fix handling of single pages from multipage TIFF files (issue tessera…
201ba0d 
…ct-ocr#2537)

That case now uses Leptonica to deliver the desired image instead of
using an inefficient loop in the Tesseract code.

See commit 54fafc4 which used similar
code in the past.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@stweil
Copy link
Member Author

stweil commented Jul 4, 2019

Travis CI failed in apt-get, so that failure is unrelated to my code change.

@egorpugin egorpugin merged commit 67ad54e into tesseract-ocr:master Jul 4, 2019
@stweil stweil deleted the tiff branch July 4, 2019 18:13
@zdenop
Copy link
Contributor

zdenop commented Jul 5, 2019

Just quick note: pixReadMemFromMultipageTiff was implemented because of #233 with "This patch reduces multipage TIFF seeks from O(n^3) to O(n)" and improved with stweil@54fafc4.

So now we are back and #233 should be rechecked...

@stweil
Copy link
Member Author

stweil commented Jul 5, 2019

Tesseract still uses pixReadMemFromMultipageTiff when all pages are processed (that was the problem reported in #233), so this use case did not change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stweil @zdenop @egorpugin