v13 #491
Merged
v13 #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use react-native-cameraroll instead. Upgraded CameraX to 1.1.0, Upgraded com.google.mlkit:barcode-scanning to 17.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Biggest change: removed camera roll / photo library integrations. This keeps the library leaner and gets around having to maintain permissions, which is a slippery slope of permissions management. It's better to handle the edge cases of permissions management using rn-permissions and library saving/loading/etc using rn-camerroll.
For moving/copying temporary files to a more permanent location, we recommend usig
expo-file-systemorreact-native-fs. Note thatreact-native-fscurrently performs poorly on large file writing and reading (moving and copying should not be affected however!)