Update to show kWh even if still charging #723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will allow user to see the the amount charged even if still charging by using charges table instead of charge_processes.
|
Didnt mean to close this, |
adriankumpf
requested changes
May 22, 2020
| @@ -234,7 +234,7 @@ | |||
| "group": [], | |||
| "metricColumn": "none", | |||
| "rawQuery": true, | |||
| "rawSql": "SELECT charge_energy_added from charging_processes where id = $charging_process_id;", | |||
| "rawSql": "SELECT charge_energy_added from charges where id = $charging_process_id order by date desc fetch first 1 row only ;", | |||
There was a problem hiding this comment.
id should be charging_process_id
There was a problem hiding this comment.
In rare cases charge_energy_added does not start a zero so that the total energy added is less than the last reported charge_energy_added (end_charge_energy_added - start_charge_energy_added to be precise). Therefore we should still prefer to display the value reported in the charging_processes table, for example:
WITH completed_charge AS (
SELECT charge_energy_added
FROM charging_processes
WHERE id = $charging_process_id
),
in_progress_charge AS (
SELECT charge_energy_added
FROM charges
WHERE charging_process_id = $charging_process_id
ORDER BY date DESC FETCH FIRST 1 ROW ONLY
)
SELECT COALESCE(completed_charge.charge_energy_added, in_progress_charge.charge_energy_added)
FROM completed_charge
JOIN in_progress_charge on trueThere was a problem hiding this comment.
Thanks, I messed up my repor and had closed out this branch... so I couldnt fix it. I will close this PR as I made a new one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will allow user to see the the amount charged even if still charging by using charges table instead of charge_processes.