Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create PR to udpate flake.lock every saturday #4372

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

brianmay
Copy link
Collaborator

If this works it should create PRs that look a bit like brianmay/robotica-rust#701

Caveats:

Copy link

netlify bot commented Nov 10, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit d4e54a9
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/6733d2de707b540008db75d9
😎 Deploy Preview https://deploy-preview-4372--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brianmay
Copy link
Collaborator Author

brianmay commented Nov 10, 2024

There is a request for native nix flake support in dependabot, but don't hold your breath waiting for it to happen :-)

dependabot/dependabot-core#7340
NixOS/nix#9823

Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
I do like the approach of having a Dependabot style for nix flake dependencies.

.github/workflows/update-flack-lock.yml Outdated Show resolved Hide resolved
.github/workflows/update-flack-lock.yml Outdated Show resolved Hide resolved
.github/workflows/update-flack-lock.yml Outdated Show resolved Hide resolved
.github/workflows/update-flack-lock.yml Show resolved Hide resolved
.github/workflows/update-flack-lock.yml Outdated Show resolved Hide resolved
@JakobLichterfeld JakobLichterfeld added github_actions Pull requests that update Github_actions code enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 11, 2024
@brianmay
Copy link
Collaborator Author

Thanks for the feedback. I agree with all points raised.

@brianmay
Copy link
Collaborator Author

Hopefully I addressed all the feedback.

I left the DeterminateSystems/nix-installer-action@main open though so you can read what I said :-)

Obviously this has not been tested...

Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, beside the pinning of the last github action

.github/workflows/update-flack-lock.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JakobLichterfeld JakobLichterfeld changed the title fix: create PR to udpate flake.lock every saturday ci: create PR to udpate flake.lock every saturday Nov 13, 2024
@JakobLichterfeld JakobLichterfeld merged commit ddfc979 into teslamate-org:master Nov 13, 2024
4 checks passed
@JakobLichterfeld
Copy link
Collaborator

@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented Nov 13, 2024

@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented Nov 13, 2024

I changed our org settings:
image

And now it succeed: https://github.com/teslamate-org/teslamate/actions/runs/11813473229/job/32910586733

--> #4381

@brianmay
Copy link
Collaborator Author

Great!

@brianmay brianmay deleted the update_flake_lock branch November 13, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants