Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Axis Labels for XY Chart in Battery Health and reduces Query count in Visited #4364

Conversation

swiffer
Copy link
Contributor

@swiffer swiffer commented Nov 8, 2024

fixes #4358 - I haven't found a way to change the min/max for X Axis only - so for now that stays as it is.
fixes #4353 - Show full VIN when no name is set

Copy link

netlify bot commented Nov 8, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit c1b2b40
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/672dc1e179cd9300082f6472
😎 Deploy Preview https://deploy-preview-4364--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@swiffer swiffer force-pushed the fix-battery-health-reduce-query-count branch from 1e8c2b9 to ce7caf2 Compare November 8, 2024 06:10
@JakobLichterfeld JakobLichterfeld added the area:dashboard Related to a Grafana dashboard label Nov 8, 2024
@swiffer swiffer marked this pull request as draft November 8, 2024 07:42
@swiffer swiffer force-pushed the fix-battery-health-reduce-query-count branch from ce7caf2 to c1b2b40 Compare November 8, 2024 07:46
@swiffer swiffer marked this pull request as ready for review November 8, 2024 07:48
@swiffer
Copy link
Contributor Author

swiffer commented Nov 8, 2024

@JakobLichterfeld - ready, lgtm (i'm planning to address #4268 and #4350 in an upcoming PR (most likely tomorrow)). would be great to cut a release afterwards.

@swiffer swiffer removed their assignment Nov 8, 2024
@JakobLichterfeld JakobLichterfeld self-assigned this Nov 8, 2024
Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
LGTM.

#4358: tested successfully
#4353: not tested on my end

@JakobLichterfeld JakobLichterfeld merged commit 6f3be51 into teslamate-org:master Nov 8, 2024
15 checks passed
@JakobLichterfeld JakobLichterfeld changed the title Fix Axis Labels for XY Chart in Battery Health and reduces Query count in Visited fix: Axis Labels for XY Chart in Battery Health and reduces Query count in Visited Nov 8, 2024
@swiffer swiffer deleted the fix-battery-health-reduce-query-count branch November 8, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard Related to a Grafana dashboard
Projects
None yet
2 participants