Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Grafana 11.1.0 & Dashboard improvements #4019

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

swiffer
Copy link
Contributor

@swiffer swiffer commented Jun 30, 2024

Closes #4018
Closes #3921

Copy link

netlify bot commented Jun 30, 2024

Deploy Preview for teslamate ready!

Name Link
🔨 Latest commit a472add
🔍 Latest deploy log https://app.netlify.com/sites/teslamate/deploys/66841e65e77027000883c9ef
😎 Deploy Preview https://deploy-preview-4019--teslamate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@swiffer
Copy link
Contributor Author

swiffer commented Jun 30, 2024

fixes #3921 improves on #4018 - @DrMichael, does it help? / @andreadam82, could you please test ?

@swiffer swiffer force-pushed the master branch 3 times, most recently from 8c20296 to 15dae16 Compare June 30, 2024 17:55
@DrMichael
Copy link
Collaborator

DrMichael commented Jul 1, 2024

@DrMichael, does it help?

Apparently not. What did you change with the Temps? I only see, that you added the inside temp to the Driver Temp, why that?

That query is running 115612.791 ms with 0 rows result... It looks as if the sort takes ages. I have 4278161 entries in the positions table.MIght be an issue for a RPiB3+ with 1GB memory?

@swiffer
Copy link
Contributor Author

swiffer commented Jul 1, 2024

I've combined 2 queries into one to reduce stress on the database.

Maybe rebuilt that index once, I wonder why it takes so long to scan that index (see issue)

@DrMichael
Copy link
Collaborator

I've combined 2 queries into one to reduce stress on the database.

Ah, I see, you use the query from Driver Temp in Inside Temp. Interesting.

@JakobLichterfeld JakobLichterfeld added area:grafana Related to Grafana area:dashboard Related to a Grafana dashboard labels Jul 2, 2024
@JakobLichterfeld JakobLichterfeld changed the title Grafana & Dashboard improvements feat: Grafana 11.1.0 & Dashboard improvements Jul 2, 2024
@swiffer
Copy link
Contributor Author

swiffer commented Jul 2, 2024

@JakobLichterfeld - plan to do some query refinements to overviews dashboard - will ping you afterwards!

@swiffer swiffer marked this pull request as draft July 2, 2024 08:01
@swiffer swiffer marked this pull request as ready for review July 2, 2024 15:34
@swiffer
Copy link
Contributor Author

swiffer commented Jul 2, 2024

@JakobLichterfeld - ready, LGTTAM (tested and merged 😄)

Copy link
Collaborator

@JakobLichterfeld JakobLichterfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JakobLichterfeld
Copy link
Collaborator

Thank you so much!

@JakobLichterfeld JakobLichterfeld merged commit 6f3757f into teslamate-org:master Jul 2, 2024
12 checks passed
@cwanja
Copy link
Collaborator

cwanja commented Jul 9, 2024

Given the issues with Grafana, should we be rolling Grafana back? Maps is a core functionality within Grafana. I understand we do not own the functionality or when the release would be pushed.

See #4070, #4029, #4068

Regardless, I do think we should push an immediate fix when Grafana releases one

@swiffer
Copy link
Contributor Author

swiffer commented Jul 9, 2024

Agree with immediatly pushing a fix after grafana releases 11.1.1 - happy to role back meanwhile instead as well (would cause some work on the shoulders of @JakobLichterfeld - sorry!)

@cwanja
Copy link
Collaborator

cwanja commented Jul 9, 2024

If the rework (not sure of the effort @JakobLichterfeld, please share) is not worth the effort, let's not go opening pandora's box.

My workaround has been a copy and pasta effort to each new discussion or issue posted.

@cwanja
Copy link
Collaborator

cwanja commented Jul 9, 2024

As an alternative, should we reopen the first reported issue to have it for tracking purposes? And then link the future PR to that issue. Been referencing #4029 with @DrMichael's response.

@cwanja
Copy link
Collaborator

cwanja commented Jul 9, 2024

Based upon the thumbs up from @JakobLichterfeld, I am going to assume we are not downgrading. Fast fingered @swiffer 😄 I am going to reopen #4055 and we can push the PR that closes that issue when Grafana releases.

@cwanja
Copy link
Collaborator

cwanja commented Jul 9, 2024

Pinned issue as well. If anyone pays attention to that 😆

@JakobLichterfeld
Copy link
Collaborator

Agree with immediatly pushing a fix after grafana releases 11.1.1 - happy to role back meanwhile instead as well (would cause some work on the shoulders of @JakobLichterfeld - sorry!)

If the rework (not sure of the effort @JakobLichterfeld, please share)

As I continuously maintain the changelog and we have put a lot of work into the CI/CD Pipeline, the effort per release is manageable. At the moment I'm only on my mobile phone, I can do the rollback and the new release (probably) tomorrow.

Based upon the thumbs up from @JakobLichterfeld, I am going to assume we are not downgrading.

😄Emoticon reaction was faster than typing

@cwanja
Copy link
Collaborator

cwanja commented Jul 9, 2024

No worries @JakobLichterfeld. Thanks for what you do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard Related to a Grafana dashboard area:grafana Related to Grafana
Projects
None yet
4 participants