-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Grafana 11.1.0 & Dashboard improvements #4019
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fixes #3921 improves on #4018 - @DrMichael, does it help? / @andreadam82, could you please test ? |
8c20296
to
15dae16
Compare
Apparently not. What did you change with the Temps? I only see, that you added the inside temp to the Driver Temp, why that? That query is running 115612.791 ms with 0 rows result... It looks as if the sort takes ages. I have 4278161 entries in the positions table.MIght be an issue for a RPiB3+ with 1GB memory? |
I've combined 2 queries into one to reduce stress on the database. Maybe rebuilt that index once, I wonder why it takes so long to scan that index (see issue) |
Ah, I see, you use the query from Driver Temp in Inside Temp. Interesting. |
@JakobLichterfeld - plan to do some query refinements to overviews dashboard - will ping you afterwards! |
@JakobLichterfeld - ready, LGTTAM (tested and merged 😄) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you so much! |
Agree with immediatly pushing a fix after grafana releases 11.1.1 - happy to role back meanwhile instead as well (would cause some work on the shoulders of @JakobLichterfeld - sorry!) |
If the rework (not sure of the effort @JakobLichterfeld, please share) is not worth the effort, let's not go opening pandora's box. My workaround has been a copy and pasta effort to each new discussion or issue posted. |
As an alternative, should we reopen the first reported issue to have it for tracking purposes? And then link the future PR to that issue. Been referencing #4029 with @DrMichael's response. |
Based upon the thumbs up from @JakobLichterfeld, I am going to assume we are not downgrading. Fast fingered @swiffer 😄 I am going to reopen #4055 and we can push the PR that closes that issue when Grafana releases. |
Pinned issue as well. If anyone pays attention to that 😆 |
As I continuously maintain the changelog and we have put a lot of work into the CI/CD Pipeline, the effort per release is manageable. At the moment I'm only on my mobile phone, I can do the rollback and the new release (probably) tomorrow.
😄Emoticon reaction was faster than typing |
No worries @JakobLichterfeld. Thanks for what you do! |
Closes #4018
Closes #3921