-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to enable and disable data collection for cars #3993
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for your suggestion. This is obviously not as permanent as removing the vehicle from the database: https://docs.teslamate.org/docs/maintenance/manually_fixing_data#remove-a-vehicle-from-the-database |
Thanks JakobLichterfeld, I agree this is not as permanent as removing the vehicle from the database. This is more for stopping data collection on active cars associated with your Tesla account. I have a car on my account that belongs to a family member and I need to prevent data collection on that car without removing driver access. |
@mark3-dev Why the feature is not yet merged: |
Is there anything else I can do? My original entry in the settings page was "Enabled" as the section title and "Enable data collection" for the text beside the slider. But after I realized that there were many different languages that the interface was translated to I changed it to Enabled for both since that was already translated in all the languages. |
I'd suggest put a 'Learn more' link and add a page under the 'Maintenance' section with more details. Including a link back to the removing a vehicle from the database details as well. Could also seeing merging that section and this PR under a 'Vehicle Management' page under 'Maintenance'. |
For now I would go with your initial suggestion. Necessary translation should not prevent us from being precise in our wording for the sake of UX. |
I'll try and get that added later today. |
Not saying you need to translate the message, we start with English |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect, ty!
* Add ability to enable and disable cars * Add default value for enabled in car_settings. * Fix unit tests. * Fix formatting. * Update text to be more descriptive * Update lables.
This feature will allow individual cars to be enabled and disabled from the settings page.
There is one new column added to the car_settings table for storing the enabled flag. It is not nullallable and has a default value of true.
When a change to the enabled value of any car it will call the existing restart method in the vehicles file.
NOTE: This will not affect any grafana dashboards other than no new data for a car will be collected.
I found two discussions that relate to this.
#3918
#1049