-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update drives.json: show drives with duration=0 but distance>0 #3867
Conversation
For discussion. I would like to show also drives, where a duration of 0 is stored, but the distance is not 0. Kind of infinite speed... :-)
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Do these "0 trips" not risk distorting other stats based on the number of trips? If so, documentation for cleaning up these trips would be usefull for me. |
They are not completely zero, they have a distance. I ran into it working on the Statistics dashboard, which did show them, but Drives did not. Either we do this change or I adapt the Statistics dashboard.
I also realised some invalid drives and some charging processes (no end_date or no significant data). Maybe removing those could be added to the documentation... |
Thank you for the clarification. I already fix incomplete with https://docs.teslamate.org/docs/maintenance/manually_fixing_data/ but maybe it’s another command to fix your invalid drives / charges |
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
If distance > 0, drive should be shown.
Ah, distance should be greater than zero... |
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
@JakobLichterfeld I still think, drives with distance > 0 should be shown. Any objections? |
I think so too. Was wondering if this is finished or not as your comment about > 0 wasn`t followed by a commit |
For discussion.
I would like to show also drives, where a duration of 0 is stored, but the distance is not 0. Kind of infinite speed... :-)
I just added
OR (duration_min = 0 AND distance >= 0)
to the WHERE clause.