Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New PCM Audio player use a AudioWorkletProcessor to offload work #46

Merged
merged 18 commits into from
Sep 30, 2023
Merged

New PCM Audio player use a AudioWorkletProcessor to offload work #46

merged 18 commits into from
Sep 30, 2023

Conversation

dvrtech-us
Copy link
Contributor

No description provided.

@dvrtech-us
moving this to the global scope so the DOM doesn't need to be read ev…
e6b7a3e 
…ery time
@dvrtech-us
Merge remote-tracking branch 'upstream/main'
ce1aa16
@dvrtech-us
Reuse the same object instead of repeating the operator multiple times
3c54f96
@dvrtech-us
correct audio toggle handling
7f39bca 
false seems to be sent as a string occasionally so lets handle it both ways
in this case if("false") is evaluating to true
@dvrtech-us
optimize pcmplayer to remove unnecessary data conversions
c372977 
Since we always use Float32, we have no need to do conversions. This yields improvements because the conversion function was rebuilding the buffer even though it was formatted correctly.
@dvrtech-us
Merge branch 'tesla-android:main' into main
0a0d34b
@dvrtech-us
Handle audio drift?
ebbbc98
@dvrtech-us
Update pcmplayer.js
bf37595
@dvrtech-us
Merge branch 'main' of https://github.com/dvrtech-us/flutter-app
1887303
@dvrtech-us
save
e3cb595
@dvrtech-us
save
ecc04d3
@dvrtech-us
New PCM player implementation
f43bcb6 
Moved Audio related JS to separate file
Implemented AudioWorkletProcessor to move message handling structure conversion and buffer out of main thread
@dvrtech-us
Update pcmplayer-processor.js
44cac6d
@dvrtech-us
Update pcmplayer-processor.js
ccdafdf
@dvrtech-us
Merge branch 'pcm-audioplayer'
342d731
@dvrtech-us
Fix Stereo support!
f23cafe
@dvrtech-us
Update pcmplayer-processor.js
a7927b1
@dvrtech-us
small improvements to initialization
7175a3b 
Now the audio socket is initialized only after pcmPlayerNode is created
Also a bug fix to properly cast gain as a float.
Seems like a latency improvement
@dvrtech-us
Copy link
Contributor Author

  • Optimized when the web socket loads so the player is ready when it starts receiving data.
  • Removed checks on the WebSocket data coming in to reduce logic in the primary thread now that the socket doesn't open until the player is ready.

@mikegapinski mikegapinski merged commit 051af4a into tesla-android:main Sep 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvrtech-us @mikegapinski